-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appdata rename #87
Appdata rename #87
Conversation
As pointed out by the official documentation: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-location /usr/share/appdata is a legacy path, that is kept for backwards compatibility purposes. The recommended path as per 2.1.2 Filesystem locations is: /usr/share/metainfo/%{id}.metainfo.xml
As noted in the parent commit, this is to adapt to the expected path of the AppStream specification.
Thanks for pointing this out! |
Another thing, the specification says the id should be an unique identifier (so not just the name, otherwise forks will conflict). So in the future it might be worth using something like |
This also makes sense to me, although I am not very fond of adding my username in here. I guess it should also be unique between this legacy Gtk version and the newer qt port. Maybe just |
well, most people use their name or the name of the organization like org.gnome (i have lots of those). I also don't know what forkid should be |
I thought this could be up to the fork, e.g. if you would maintain one and like to call it after your username If it is common practice to use the username though, I am not fully reluctant to |
well if i forked vimiv then it would be could be vimiv-qt or vimiv-gtk ? |
If I read the standard you linked in the commit correctly, hyphens are discouraged. It seems like underscores could be valid, so maybe: This is somehow more complicated than expected 😃 Thanks for your help! |
* Rename to `org.karlch.vimiv.qt.metainfo.xml`. This is in conformity with the newer `metainfo` instead of the deprecated `appdata` and provides a more unique id compared to the basic `vimiv`. * Fix a few URLs that pointed to the Gtk version. * Extend information. See the discussion in karlch/vimiv#87 for further information.
See the discussion in #87 for further information.
I have adjusted this in the two referenced commits for the corresponding fork. Thanks again! |
The rationale is stored in the commit's messages, most specifically in the first one