Skip to content

Commit

Permalink
Issue webcompat#609 - Removes the set_cache_control
Browse files Browse the repository at this point in the history
  • Loading branch information
karlcow committed Feb 10, 2017
1 parent 2f8c333 commit 71c71ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
9 changes: 3 additions & 6 deletions webcompat/helpers.py
Expand Up @@ -5,6 +5,8 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.

from datetime import datetime
from functools import wraps
from functools import update_wrapper
import hashlib
import json
import math
Expand All @@ -16,6 +18,7 @@
from babel.dates import format_timedelta
from flask import abort
from flask import g
from flask import make_response
from flask import request
from flask import session
from form import IssueForm
Expand Down Expand Up @@ -458,11 +461,5 @@ def api_request(method, path, params=None, data=None):
abort(404)


def set_cache_control(response, seconds):
'''Adds Cache-Control headers with x seconds.

one day = 86400 seconds. The Cache is set as private.
'''
caching_header = 'private, max-age={time}'
response.headers['Cache-Control'] = caching_header.format(time=seconds)
return response
3 changes: 0 additions & 3 deletions webcompat/views.py
Expand Up @@ -25,7 +25,6 @@
from helpers import get_form
from helpers import get_referer
from helpers import get_user_info
from helpers import set_cache_control
from helpers import set_referer
from issues import report_issue
from webcompat import app
Expand Down Expand Up @@ -211,8 +210,6 @@ def show_issue(number):
session.pop('show_thanks')
content = render_template('issue.html', number=number)
response = make_response(content)
# We can cache for one year. Etag is based on the content.
response = set_cache_control(response, 31536000)
response.add_etag(content)
# Return a 304 Not Modified when matching the Etag
return response.make_conditional(request)
Expand Down

0 comments on commit 71c71ba

Please sign in to comment.