More diagnostic/error rules (html[lang], title, legend, [dir], meta refresh (!) and input[type="image"]) and a test file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlgroves
pushed a commit
that referenced
this pull request
May 22, 2013
More diagnostic/error rules (html[lang], title, legend, [dir], meta refresh (!) and input[type="image"]) and a test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
after forking your existing stylesheet, I added a few rules to detect and display:
html[lang],title(s) at top of page, flagging duplicates and empty ones (forgot abouttitlenot inhead),legendnot being the first element of afieldset(and other element being the first child of the latter),[dir]whetherrtlorltr,<meta>refresh (!) (found the selector in Accessibility First step from Opquast/Temesis, credit is in the comments of the CSS)input[type="image"]and emptyaltattribute or lack of (no:beforeor:afterwith this element so it's hard to flag it in pure CSS. Maybe in the future with a base64-encoded background?)A few links to WCAG 2.0 Techniques are in the comment of some of the rules.
I also added a test file for legends with a valid example and a bad one (I hope so). In this file, each select has a different kind of label; this is intended :)
Feel free to tell me if this is or isn't the kind of CSS rules and display you'd like to see in diagnostic.css, I've an extensive list of ideas taken from the Accessiweb 2.2 checklist and other tools :)
Best regards,
Ph. Vayssière