Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources.smscalls: propogate errors if there are breaking schema changes #386

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

seanbreckenridge
Copy link
Contributor

@seanbreckenridge seanbreckenridge commented Apr 15, 2023

related to: karlicoss/HPI#289

Am unsure if CI here will fail till the return type from HPI is updated, but I think the change is small enough should be able to merge after publishing a release there...

Just to show works locally with new types:

$ mypy -p promnesia.sources.smscalls
Success: no issues found in 1 source file

$ hpi doctor -S promnesia.sources.smscalls
✅ OK  : promnesia.sources.smscalls                        
✅     - stats: {'index': {'index': {'count': 371, 'last': datetime.datetime(2023, 4, 14, 20, 6, 18, 459000, tzinfo=datetime.timezone.utc)}}}

@karlicoss
Copy link
Owner

I think mypy can complain about unnecessary None checks, but it's a custom flag which we don't have :)

@karlicoss karlicoss merged commit f8525e7 into karlicoss:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants