Ensure tombstones created before kubexit started are read #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8
This commit changes the
Watch
function inside thetombstone
package to also emit an initial event besides thefsnotify
events. This initial event is called immediatly whenWatch
is called and the watcher has been setup.This change allows kubexit to detect tombstones written before kubexit was started. This prevents possible race conditions as described by #8.
In order for this change to work, the
tombstone.EventHandler
type was changed. It now requires a function with 3 arguments: The graveyard, the tombstone and the operation instead of anfsnotify.Event
. Reason being that the initial event is not anfsnotify.Event
. The functions implementing atombstone.EventHandler
are changed accordingly.This change on its own introduces a new bug where the tombstone is written as part of an initial event, but the child process will still start because
child.Start()
is being called after the watcher has been setup. To overcome this issue, the shutdown state of the child is tracked in a new flag, which is set ifShutdownNow()
orShutdownWithTimeout()
is executed.