Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when generating Reason was being incorrectly populated #30

Merged
merged 49 commits into from
Jun 12, 2024

Conversation

karlssberg
Copy link
Owner

Fixed issue where a few of the WhenTrue and WhenFalse overloads were causing the Reason property to use the propositional statement instead of the assertion
Updated docs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
Motiv/AsAllSatisfiedExtensions.cs 100.00% <ø> (ø)
Motiv/AssertionExtensions.cs 100.00% <100.00%> (ø)
...tionBuilders/BooleanPredicatePropositionBuilder.cs 88.23% <ø> (+11.76%) ⬆️
Motiv/BooleanResultBase.cs 83.07% <ø> (ø)
...on/BooleanResultPredicateExplanationProposition.cs 92.59% <ø> (ø)
...ilders/BooleanResultPredicatePropositionBuilder.cs 100.00% <100.00%> (ø)
...ion/FalseAssertionExplanationPropositionBuilder.cs 100.00% <100.00%> (ø)
...ion/MultiAssertionExplanationPropositionFactory.cs 100.00% <100.00%> (ø)
Motiv/EnumerableExtensions.cs 73.01% <100.00%> (+5.15%) ⬆️
Motiv/Explanation.cs 78.94% <100.00%> (ø)
... and 5 more

... and 6 files with indirect coverage changes

@karlssberg karlssberg merged commit 091a257 into main Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants