Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts when noncurses mode in large terminals #379

Closed
Phate6660 opened this issue Aug 22, 2020 · 6 comments
Closed

Artifacts when noncurses mode in large terminals #379

Phate6660 opened this issue Aug 22, 2020 · 6 comments

Comments

@Phate6660
Copy link

I can see that it works, however there are a lot of artifacts that stay there unless I do something like change the bar size.

dCtnKwqCtO

@karlstav
Copy link
Owner

@Phate6660 please use the bug report form to provide more detail


When/where was the bug introduced?

    Are you using cava from a package repository, like AUR?
    If so, check out the master branch here, is your issue already resolved?
    Don't know how to clone, compile source code? File report to package maintainer instead.
    try using git bisect to find out where the bug was introduced.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

    Set config parameter to
    run
    do something
    See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

    OS: [e.g. macOS, Ubuntu]
    Version [e.g. 22]

Terminal emulator

    name
    version

Additional context
Add any other context about the problem here.

@Phate6660
Copy link
Author

When/where was the bug introduced?

Latest master, just `git clone`d a couple days ago.

Describe the bug
Visual artifacts remain on screen while cava runs, though the visualizer itself does technically work, it's just blocked by all the artifacts.

To Reproduce
Steps to reproduce the behavior:

Set input to alsa, use hw:Loopback,1 source
run
See error

Expected behavior
The visualizer running without leaving all the blocks on screen. They only go away when I do something like change the bar size.

Screenshots
See first post.

Desktop (please complete the following information):

OS: Gentoo

Terminal emulator

both uxterm (xterm) and alacritty
351 for xterm, 0.6.0-dev for alacritty

@karlstav
Copy link
Owner

They only go away when I do something like change the bar size.

does the artifacts come back?

from your screen shot it looks like you are using a very large terminal, is it the same with a smaller window (less then 100x100)

how does it look in a TTY or with ncurses output mode?

there has been some memory fixes lately that could be related, could you pull latest version and test?

@karlstav
Copy link
Owner

@Phate6660, actually I just found out that there are some quirks in the noncurses mode that could lead to this kind of behavior.

can you confirm that the issue is resolved by changing to ncurses output mode in the cava config?

karlstav added a commit that referenced this issue Aug 24, 2020
glitches doesn't look as bad as before, might have been related to
poor gpu/cpu performance/drivers

also noncurses mode had some quirks #379
@Phate6660
Copy link
Author

I am sorry, I would've responded sooner but I had to deal with a bunch of trouble when installing a new GPU.

After git pulling and rebuilding, it works completely as expected! Thank you!

@karlstav
Copy link
Owner

most likely related to ncurses now being default.

@karlstav karlstav changed the title Artifacts when using with ALSA loopback device Artifacts when noncurses mode in large terminals Aug 26, 2020
karlstav added a commit that referenced this issue Aug 26, 2020
…key controls in noncurses mode, disabling it
karlstav added a commit that referenced this issue Nov 28, 2023
uses read() with VMIN and VTIME set to 0

have yet to notice the same issues we had with #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants