Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS input backend and general improved FreeBSD support #540

Merged
merged 2 commits into from Dec 31, 2023

Conversation

bsdcode
Copy link
Contributor

@bsdcode bsdcode commented Dec 31, 2023

  • OSS: add 'enable-oss-input' configure option
  • OSS: set to default input method if enabled
  • sndio: add to input method selection sequence with high priority
  • sndio: fix small bug in channel setting
  • FreeBSD: add 'enable-cava-font' configure option, which creates vt(4) font cava.fnt from cava.psf
  • doc: extended documentation in example config file and in README.md

- OSS: add 'enable-oss-input' configure option
- OSS: set to default input method if enabled
- sndio: add to input method selection sequence with high priority
- sndio: fix small bug in channel setting
- FreeBSD: add 'enable-cava-font' configure option, which creates vt(4) font cava.fnt from cava.psf
- doc: extended documentation in example config file and in README.md
@karlstav
Copy link
Owner

the build on linux fails @bsdcode.

input/oss.c:16:49: error: ‘AFMT_S32_LE’ undeclared (first use in this function); did you mean ‘AFMT_S16_LE’?
...

looks like normal ubuntu also have the sys/soundcard.h so it tries to build the oss.c.

should it have worked? Not sure how linux relates to oss.

maybe just make the check so it only builds oss on freebsd. not sure if we can have github runners on freebsd, but would be nice in this case.

@bsdcode
Copy link
Contributor Author

bsdcode commented Dec 31, 2023

I didn't know that ubuntu (or any linux distro) includes a sys/soundcarde.h by default. In general OSS can be built on linux, but it's AFAIK not common and it would differ anyway. I would rather limit it to the FreeBSD built as you suggest. I will update the configure.ac.

I have no experience with github runners, but I can have a look at it.

@karlstav
Copy link
Owner

Looks like it's only linux, mac and windows.

@karlstav karlstav merged commit 1e3708a into karlstav:master Dec 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants