fix source being ignored when using pipewire #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @gardk, I always found these settings a bit flimsy in pipewire. In my case now the source is ignored both with and without your commit. Maybe it is related to the fact that I am on ubuntu and stuck with pipewire 0.3.79 |
Closed
|
there it worked, not sure why. maybe my pipewire was in some faulty state, |
|
Nice, so you got it tested that it did what it says it did? I was a bit worried when you merged and it wasn't working for you :P |
|
yes, I can now specify a client like spotify and pause the music to reproduce the issue. What is strange is that if i specify some random string as the source it will still use the default output. Might just be a feature in pipewire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that whatever I put in the source field of [input] was always ignored by cava when using PipeWire.
This PR fixes that issue, but it also brings out another issue that is actually reproducible without this patch. Described in #556.
Haven't been able to track down why that's happening.