refactor addCharacter

karlyanelson · Jan 13, 2021 · 51ab82e · 51ab82e
1 parent dfacf33
commit 51ab82e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/js/handlers/clickHandler.js b/src/js/handlers/clickHandler.js
@@ -28,7 +28,7 @@ export default function clickHandler(event) {
   }
 
   if (buttonTarget.matches("#addCharacter")) {
-    addCharacter(DATA_STORE);
+    addCharacter();
   }
 
   if (buttonTarget.matches("[data-zoom]")) {

diff --git a/src/js/utils/addCharacter.js b/src/js/utils/addCharacter.js
@@ -1,22 +1,23 @@
 import { generateRandomID } from "./utils";
 import { DEFAULT_COLOR } from "../globals/variables";
+import DATA_STORE from "../globals/store";
 
-export default function addCharacter(store) {
-  const numOfCharacters = (store.data.characters.length + 1).toString();
+export default function addCharacter() {
+  const numOfCharacters = (DATA_STORE.data.characters.length + 1).toString();
 
-  const zoomRatio = store.data.zoom / 100;
+  const zoomRatio = DATA_STORE.data.zoom / 100;
   const positiveOrNegative = Math.random() < 0.5 ? -1 : 1;
   const randomNumberX =
     Math.floor(Math.random() * Math.floor(40)) * positiveOrNegative;
   const randomNumberY =
     Math.floor(Math.random() * Math.floor(40)) * positiveOrNegative;
   const posX =
     (window.innerWidth / 2 + window.pageXOffset) / zoomRatio -
-    store.data.pieceSize / 2 +
+    DATA_STORE.data.pieceSize / 2 +
     randomNumberX;
   const posY =
     (window.innerHeight / 2 + window.pageYOffset) / zoomRatio -
-    store.data.pieceSize / 2 +
+    DATA_STORE.data.pieceSize / 2 +
     randomNumberY;
 
   var newCharacter = {
@@ -34,5 +35,5 @@ export default function addCharacter(store) {
     y: posY,
     size: 1,
   };
-  store.data.characters.push(newCharacter);
+  DATA_STORE.data.characters.push(newCharacter);
 }