Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Commit

Permalink
Merge pull request #3 from L42y/os_version
Browse files Browse the repository at this point in the history
feat: os version option
  • Loading branch information
vojtajina committed Aug 19, 2013
2 parents 48deb3b + 3bbccf4 commit 6852d77
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,15 @@ module.exports = function(config) {
bs_firefox_mac: {
base: 'BrowserStack',
browser: 'firefox',
os: 'mac',
os: 'OS X',
os_versio: 'Mountain Lion',
version: '21.0'
},
bs_iphone5: {
base: 'BrowserStack',
device: 'iPhone 5',
os: 'ios',
version: '6.0'
os_version: '6.0'
}
},

Expand All @@ -70,6 +71,7 @@ module.exports = function(config) {
- `browser` name of the browser
- `version` version of the browser
- `os` which platform ?
- `os_version` version of the platform

For an example project of, check out Karma's [e2e test](https://github.com/karma-runner/karma/tree/master/test/e2e/browserstack).

Expand Down
5 changes: 3 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
var captured = false;
var log = logger.create('launcher.browserstack');
var browserName = (args.browser || args.device) + (args.version ? ' ' + args.version : '') +
(args.os ? ' (' + args.os + ')' : '') + ' on BrowserStack';
' (' + args.os + ' ' + args.os_version + ')' + ' on BrowserStack';

this.id = id;
this.name = browserName;
Expand All @@ -82,9 +82,10 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
// TODO(vojta): handle non os/browser/version
var settings = {
os: args.os,
os_version: args.os_version,
device: args.device,
browser: args.browser,
version: args.version || 'latest',
browser_version: args.version || 'latest',
url: url + '?id=' + id
};

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],
"author": "Vojta Jina <vojta.jina@gmail.com>",
"dependencies": {
"browserstack": "~0.2.0",
"browserstack": "~1.0",
"browserstacktunnel-wrapper": "~1.0.1",
"q": "~0.9.6"
},
Expand Down

0 comments on commit 6852d77

Please sign in to comment.