Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Commit

Permalink
fix: use browser_version as per v3 API
Browse files Browse the repository at this point in the history
  • Loading branch information
vojtajina committed Aug 19, 2013
1 parent 6852d77 commit a435a8f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
12 changes: 4 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@

> Use any browser on [BrowserStack](http://www.browserstack.com/)!
**NOTE:** You have to run local tunnel first:
```bash
$ java -jar BrowserStackTunnel.jar <KEY> localhost,9876,0
```


## Installation

Expand Down Expand Up @@ -43,9 +38,9 @@ module.exports = function(config) {
bs_firefox_mac: {
base: 'BrowserStack',
browser: 'firefox',
browser_version: '21.0',
os: 'OS X',
os_versio: 'Mountain Lion',
version: '21.0'
os_version: 'Mountain Lion'
},
bs_iphone5: {
base: 'BrowserStack',
Expand All @@ -69,10 +64,11 @@ module.exports = function(config) {
### Per browser options
- `device` name of the device
- `browser` name of the browser
- `version` version of the browser
- `browser_version` version of the browser
- `os` which platform ?
- `os_version` version of the platform


For an example project of, check out Karma's [e2e test](https://github.com/karma-runner/karma/tree/master/test/e2e/browserstack).


Expand Down
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ var BrowserStackBrowser = function(id, emitter, args, logger,
os_version: args.os_version,
device: args.device,
browser: args.browser,
browser_version: args.version || 'latest',
// TODO(vojta): remove "version" (only for B-C)
browser_version: args.browser_version || args.version || 'latest',
url: url + '?id=' + id
};

Expand Down

0 comments on commit a435a8f

Please sign in to comment.