Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support baseline to display zero coverage for "untouched" files #11

Open
vojtajina opened this issue Aug 14, 2013 · 9 comments
Open

Support baseline to display zero coverage for "untouched" files #11

vojtajina opened this issue Aug 14, 2013 · 9 comments

Comments

@vojtajina
Copy link
Contributor

Currently, files that are never executed are not included in the report (even if they are instrumented).

This can be implemented using BaselineCollector gotwarlost/istanbul@092f336

@vojtajina
Copy link
Contributor Author

One possible solution:

ThomasYoung283 added a commit to ThomasYoung283/karma-coverage that referenced this issue Dec 30, 2013
Add the ability to include baseline JavaScript code coverage.

Closes karma-runner#11
@vijtad
Copy link

vijtad commented Jan 15, 2014

Can you give an example how this switch includeBaseline can be used.
Is this switch true by default ?

@vijtad
Copy link

vijtad commented Jan 16, 2014

I found, we need to add the following switch in karma config js file.

includeBaseline : true,

@vijtad
Copy link

vijtad commented Jan 18, 2014

I used following package for these changes and I don't see your code changes.

Can you pls. let me know the correct command to pull your karma-coverage changes

{
"name": "ng-directive-testing",
"version": "0.0.0",
"description": "An example of testing AngularJS directives with Karma.",
"main": "",
"scripts": {
"test": "karma start --single-run --no-auto-watch"
},
"repository": {
"type": "git",
"url": "git://github.com/vojtajina/ng-directive-testing.git"
},
"author": "Vojta Jina vojta.jina@gmail.com",
"license": "MIT",
"devDependencies": {
"karma": "~0.10.8",
"karma-jasmine": "~0.1.3",
"karma-chrome-launcher": "~0.1.1",
"karma-phantomjs-launcher": "~0.1.1",
"karma-ng-html2js-preprocessor": "~0.1.0",
"karma-coverage": "~0.1.4",
"karma-junit-reporter": "~0.2.1"
}
}

Thanks,
Vijay

@robmcguinness
Copy link

+1

1 similar comment
@dnoler
Copy link

dnoler commented Feb 28, 2014

+1

nchase pushed a commit to nchase/karma-coverage that referenced this issue Apr 19, 2014
Add the ability to include baseline JavaScript code coverage.

Closes karma-runner#11
@nchase
Copy link

nchase commented Sep 2, 2014

@vojtajina can you take a look at my pull request here? This issue is old but people are still commenting on the pull request as it is something they want.

@arkist
Copy link

arkist commented Sep 17, 2014

+1. is there anything wrong with @nchase's PR?

@czers
Copy link

czers commented Oct 1, 2014

+1 - this feature is clearly missing from karma-coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants