Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoffeeScript coverage preprocessor doesn't change file extension to .js #177

Closed
les2 opened this issue Aug 20, 2015 · 4 comments · Fixed by #194 · 4 remaining pull requests
Closed

CoffeeScript coverage preprocessor doesn't change file extension to .js #177

les2 opened this issue Aug 20, 2015 · 4 comments · Fixed by #194 · 4 remaining pull requests

Comments

@les2
Copy link
Contributor

les2 commented Aug 20, 2015

I'm following this example .

The behavior causes problems when using requirejs, which will automatically add a .js extension to resources it requests.

Here is an example that demonstrates the problem (which is based off the coffee example in this repo).

See this commit message for more details: les2@b8839d6

This example can serve as documentation for others if we get it working / implement a fix.

@les2
Copy link
Contributor Author

les2 commented Aug 20, 2015

Updated description with link to example demonstrating the problem.

@les2
Copy link
Contributor Author

les2 commented Sep 2, 2015

Thanks for labeling @dignifiedquire .

Let me know if I can help in any way (e.g., providing debug logs).

@kmdavis
Copy link

kmdavis commented Oct 5, 2015

+1

Also @les2 there is a rather old and out of date fork davidosomething/karma-coverage that works for me using coffeescript and requirejs

@les2
Copy link
Contributor Author

les2 commented Oct 15, 2015

Also @les2 there is a rather old and out of date fork davidosomething/karma-coverage that works for me using coffeescript and requirejs

@kmdavis Took a look and it seems like the code around this line needs to be ported to this karma (not positive, but hopeful). I hope to get a PR together with this change incorporated before long. Thanks for pointing this out!

les2 pushed a commit to les2/karma-coverage that referenced this issue Nov 13, 2015
Adds support for using RequireJS with CoffeeScript code by changing
the file extension from `.coffee` to `.js`. RequireJS automatically
adds the `.js` suffix to files and it doesn't seem possible to change
it.

Closes karma-runner#177
les2 pushed a commit to les2/karma-coverage that referenced this issue Nov 13, 2015
Adds support for using RequireJS with CoffeeScript code by changing
the file extension from `.coffee` to `.js`. RequireJS automatically
adds the `.js` suffix to files and it doesn't seem possible to change
it.

Closes karma-runner#177
les2 pushed a commit to les2/karma-coverage that referenced this issue Nov 13, 2015
Adds support for using RequireJS with CoffeeScript code by changing
the file extension from `.coffee` to `.js`. RequireJS automatically
adds the `.js` suffix to files and it doesn't seem possible to change
it.

Closes karma-runner#177
les2 pushed a commit to les2/karma-coverage that referenced this issue Nov 13, 2015
Adds support for using RequireJS with CoffeeScript code by changing
the file extension from `.coffee` to `.js`. RequireJS automatically
adds the `.js` suffix to files and it doesn't seem possible to change
it.

Closes karma-runner#177
les2 pushed a commit to les2/karma-coverage that referenced this issue Nov 14, 2015
Adds support for using RequireJS with CoffeeScript code by changing
the file extension from `.coffee` to `.js`. RequireJS automatically
adds the `.js` suffix to files and it doesn't seem possible to change
it.

Closes karma-runner#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment