Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preprocessor) Reset coverageObjRegex before each use #176

Merged
merged 1 commit into from Sep 8, 2015

Conversation

terussell85
Copy link

When using the includeAllSources flag, every other non-tested file is included. This appears to be because the coverageObjRegex is global and shared. Resetting the regex allows files to match correctly when coverageObjRegex.exec() is called.

Likely to help partially resolve #166, if not completely.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@terussell85
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link

CLAs look good, thanks!

@terussell85
Copy link
Author

The ESlint issues causing the CI to fail are in files unchanged by this PR. To keep changes in the PR isolated, it seems that the ESlint fixes should be done elsewhere.

@dignifiedquire
Copy link
Member

Thanks :octocat: will merge and release tomorrow.

@dignifiedquire dignifiedquire self-assigned this Aug 23, 2015
dignifiedquire added a commit that referenced this pull request Sep 8, 2015
fix(preprocessor) Reset coverageObjRegex before each use
@dignifiedquire dignifiedquire merged commit fec0b75 into karma-runner:master Sep 8, 2015
@dignifiedquire
Copy link
Member

Thanks and sorry for the delay. Released as 0.5.2

@djmc
Copy link

djmc commented Sep 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

includeAllSources does not work as expected
4 participants