Paths in windows use backslash (fixes #178) #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Hmmm.... it appears as though some unrelated code is causing CI to go into failure. |
|
Thanks, you can ignore the ci failures, I need to fix those in |
When istanbul creates a report combining json files from multiple sources with different path separaters, all files are listed with the full absolute path. If path separators are consistent between json files, all files are relative to a common base, and everything looks much nicer. Closes karma-runner#178
tswaters
force-pushed
the
windows-paths
branch
from
f99a826
to
b0eecbe
Compare
|
I've updated the commit message. |
|
Thanks a lot |
dignifiedquire
added a commit
that referenced
this pull request
Aug 28, 2015
Paths in windows use backslash (fixes #178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures paths are using backslashes in windows, consistent with outputs from istanbul.