-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to lib-istanbul-api #251
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I'm really interested in this, given that the current istanbul used by karma-coverage is dead in favor of the new library (and they have made significant performance improvements). Are there any plans by the maintainers to finish this up and merge it? |
This is needed, but I don't think I will have time to work on it anytime soon. |
What's the chance of a (cleanly made) pull request to be accepted, even if some features - e.g. like coverage check - are still missing? |
CLAs look good, thanks! |
I would be okay with merging it into a |
Any progress on this? |
I had no time to work further on this. |
what kind of task is not done yet? |
closing old PRs, sorry. I will try to keep up to new ones. |
A very early draft of an upgrade to lib-istanbul-api. The configuration differs from the existing one (uses the format of istanbul-api) and features like check coverage are still missing. But it might be a good start if someone wants to seriously upgrade to lib-istanbul-api.
I just wanted to share it, if it is not needed, just close the pull request,
Cheers.