Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to lib-istanbul-api #251

Closed
wants to merge 1 commit into from

Conversation

MichaReiser
Copy link

A very early draft of an upgrade to lib-istanbul-api. The configuration differs from the existing one (uses the format of istanbul-api) and features like check coverage are still missing. But it might be a good start if someone wants to seriously upgrade to lib-istanbul-api.

I just wanted to share it, if it is not needed, just close the pull request,

Cheers.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mramato
Copy link

mramato commented Sep 8, 2016

I'm really interested in this, given that the current istanbul used by karma-coverage is dead in favor of the new library (and they have made significant performance improvements). Are there any plans by the maintainers to finish this up and merge it?

@dignifiedquire
Copy link
Member

This is needed, but I don't think I will have time to work on it anytime soon.

@MichaReiser
Copy link
Author

What's the chance of a (cleanly made) pull request to be accepted, even if some features - e.g. like coverage check - are still missing?

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

I would be okay with merging it into a beta branch on here, and publish as a beta version to npm. But for it to go into a regular release we need feature parity with what is currently there.

@ghost
Copy link

ghost commented Jun 12, 2017

Any progress on this?

@MichaReiser
Copy link
Author

I had no time to work further on this.

@sukrosono
Copy link

what kind of task is not done yet?

@johnjbarton
Copy link
Contributor

closing old PRs, sorry. I will try to keep up to new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants