Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make travis file simpler #386

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Make travis file simpler #386

merged 2 commits into from
Sep 30, 2019

Conversation

anthony-redFox
Copy link
Collaborator

  • move xvfb to services
  • Remove update npm (it was need for old versions of node)

@johnjbarton
Copy link
Contributor

Please add to the description (esp. links to travis docs) why you think the older code is not needed.

@anthony-redFox
Make travis file simpler
09125ef 
the are two reasons
1. Since of May 2019 by default start Ubuntu Xenial 16.04
https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
2. and also since Ubuntu 16.04 you can start xvfb as services
https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-xvfb-to-run-tests-that-require-a-gui

 - move xvfb to services
 - Remove update npm (it was need for old versions of node)
@anthony-redFox
travis executes export DISPLAY=:99.0 when service xvfb start and don'…
43dff7f 
…t need repeat again
@anthony-redFox
Copy link
Collaborator Author

Added in commit message:
the are two reasons

  1. Since of May 2019 by default start Ubuntu Xenial 16.04
    https://blog.travis-ci.com/2019-04-15-xenial-default-build-environment
  2. and also since Ubuntu 16.04 you can start xvfb as services
    https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-xvfb-to-run-tests-that-require-a-gui

done @johnjbarton

@anthony-redFox anthony-redFox mentioned this pull request Sep 30, 2019
Merged
@johnjbarton johnjbarton merged commit 9c8a222 into karma-runner:master Sep 30, 2019
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anthony-redFox @johnjbarton @karmarunnerbot