Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer not found #14

Closed
cthorne66 opened this issue Mar 19, 2014 · 5 comments · Fixed by #22
Closed

Internet Explorer not found #14

cthorne66 opened this issue Mar 19, 2014 · 5 comments · Fixed by #22
Assignees

Comments

@cthorne66
Copy link

WARN [plugin]: Error during loading "... /node_modules/karma-ie-launcher" plugin:
Internet Explorer not found

I have unit tests suites being run on multiple machines & virtual instances. This includes Mac and Windows OS. My Grunt file takes care of which browsers to execute against, based on the operating system. Up until v0.1.1 of this plugin, I wasn't having any issues, but since 0.1.2 I can now see the above warning in the console.

I can see where a warning/error would make sense if I was trying to run tests against an IE browser on a Mac, but since it's not, can this warning/error be suppressed? Or, do you have any other suggestions?

The error is being thrown inside of the getInternetExplorerExe() function in index.js

Thank you very much
Chris

screen shot 2014-03-19 at 3 06 36 pm

@sylvain-hamel
Copy link
Contributor

Have you considered handling this in your karma.config (or gruntfile):

var isWin = /^win/.test(process.platform);
...
config.set({
    browsers : isWin ? ['IE', 'Chrome'] : [Chrome]
});

@bcbailey
Copy link

bcbailey commented Apr 1, 2014

I use litixsoft/karma-detect-browsers to automatically detect whatever browsers are on a users local machine. It adds karma-ie-launcher (among others) as a dependency to my project and so that gets installed even on my mac. By default karma loads all npm modules that start with karma-*, and this error occurs as soon as this launcher is required.

This behavior is inconsistent with the other launchers (ie: karma-opera-launcher, karma-chrome-launcher, etc.)

I understand the reason for the error, but is there any way to move the error message to a later time? Such as when the browser is actually attempted to be used? Or remove it and be consistent with the other launchers?

@sylvain-hamel
Copy link
Contributor

Ok, I'll look into that possibility of delaying the moment when we throw the error until we are ready to spawn the process. I'll get back to you soon.

@sylvain-hamel sylvain-hamel self-assigned this Apr 1, 2014
@cthorne66
Copy link
Author

@sylvain-hamel, I do actually have that check you mentioned setting the option in the gruntfile.js for my Karma config. Unfortunately it still throws an error, though the IE browser is never actually invoked.

Thanks for your help!

@sylvain-hamel
Copy link
Contributor

I see. I agree that it doesn't really make sense to throw just because the plug-in is loaded.

sylvain-hamel added a commit to sylvain-hamel/karma-ie-launcher that referenced this issue Apr 2, 2014
sylvain-hamel added a commit to sylvain-hamel/karma-ie-launcher that referenced this issue Apr 2, 2014
instead of failing as soon as the plug-in is loaded
closes karma-runner#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants