Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jasmine from NPM #7

Closed
OliverJAsh opened this issue Aug 29, 2013 · 13 comments
Closed

Use Jasmine from NPM #7

OliverJAsh opened this issue Aug 29, 2013 · 13 comments

Comments

@OliverJAsh
Copy link

Is there any reason why Jasmine is bundled with karma-jasmine instead of listed as a dependency? This caused me some trouble when debugging…

@ghost
Copy link

ghost commented Sep 10, 2013

Is it actually bundled with karma-jasmine?? This needs to be documented :/

I was looking for a jasmine package to install from npm and I can't find anyone who is stating exactly which package to work with (such as jasmine-standalone, jasmine-node or jasmine-jquery). What gives? 😭

@what-is-a-crow
Copy link

+1

This feels strange.

@vojtajina
Copy link
Contributor

The reason for this is that Karma ships with a custom fork that supports iit/ddescribe. See https://groups.google.com/d/topic/jasmine-js/SDlib9ruSQo/discussion and jasmine/jasmine#181

@OliverJAsh
Copy link
Author

@vojtajina You could reference the forked version via Bower?

@vojtajina
Copy link
Contributor

Then I will have to maintain a bower repo for it. Let's not go there;-)

With Jasmine 2.0 I made the iit/ddescribe a hack in a separate file so
updating will be easier so I think it's fine if we ship karma-jasmine with
the latest version of Jasmine. You can easily override and load any version
of Jasmine you like - just put it in files.

On Sat, Feb 15, 2014 at 1:47 PM, Oliver Joseph Ash <notifications@github.com

wrote:

@vojtajina https://github.com/vojtajina You could reference the forked
version via Bower?

Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-35168964
.

@msarchet
Copy link

Is there any resolution to actually updating to the newest version of Jasmine?

@nikku
Copy link

nikku commented Jun 25, 2014

You can easily override and load any version
of Jasmine you like - just put it in files.

Doesn't that fix it?

@jiverson
Copy link
Contributor

jiverson commented Sep 1, 2014

I created a pull-request to fix this issue so that it will use jasmine-core as a peer dependency, similar to how karma-mocha works. #45

@scottillogical
Copy link

+1

@bostrom
Copy link

bostrom commented Oct 10, 2014

You can easily override and load any version
of Jasmine you like - just put it in files.

Can you elaborate on this a bit? What files are you talking about?

@maksimr
Copy link
Contributor

maksimr commented Oct 10, 2014

@bostrom about property files in karma.config.js

@jfilip
Copy link

jfilip commented Oct 30, 2014

+1

@maksimr
Copy link
Contributor

maksimr commented Nov 6, 2014

Made in #55
and will available in karma-jasmine@0.3

@maksimr maksimr closed this as completed Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants