Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for outputDir #54

Closed
stevebroshar opened this issue Jul 31, 2015 · 6 comments
Closed

Set default value for outputDir #54

stevebroshar opened this issue Jul 31, 2015 · 6 comments

Comments

@stevebroshar
Copy link

I just upgraded karma-junit-reporter from v0.2.2 to v0.3.3. Test runs fail with error: "You must set an output directory for JUnitReporter via the outputDir config property". It seems that this setting had a default value before, but is now required. Can we please revert to the default value? It was working just fine. Thanks.

@jatwork
Copy link

jatwork commented Aug 12, 2015

Experienced the same issue here. I believe the rewrite from v0.2.2 to 0.3.x breaks this:
v0.2.2...v0.3.1

@dignifiedquire
Copy link
Member

If you want the old behaviour back, you can for now just set outputDir: ''.

@dignifiedquire dignifiedquire changed the title Error: You must set an output directory for JUnitReporter via the outputDir config property Set default value for outputDir Aug 13, 2015
@stevebroshar
Copy link
Author

Thanks for feedback. It's good to know that setting outputDir to blank results in the old behavior WRT where the file is written. But, my suggestion is that the behavior should be like this by default ... that it should act as if outputDir is blank when it's not explicitly set.

@rcollette
Copy link

On my mac, the expression if (!reporterConfig.outputDir) evaluates to true with outputDir is set to ''. There doesn't seem to be a workaround in my case.

@sfri
Copy link

sfri commented Aug 19, 2015

Same problem here: !reporterConfig.outputDir evaluates to true on linux (Ubuntu 14.04)

@bra1n
Copy link

bra1n commented Aug 21, 2015

You could try by setting outputDir: '.' which will be the current working directory. That removed the error message for me (on Mac) and did not affect the behaviour.

janeklb pushed a commit to janeklb/karma-junit-reporter that referenced this issue Aug 21, 2015
janeklb pushed a commit to janeklb/karma-junit-reporter that referenced this issue Aug 23, 2015
dignifiedquire added a commit that referenced this issue Aug 28, 2015
set default value of outputDir to '.', fixes #54
dignifiedquire pushed a commit that referenced this issue Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants