Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore suite in classname for old XML #184

Merged

Conversation

jason-ha
Copy link
Contributor

@jason-ha jason-ha commented Sep 2, 2020

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@jpaulin jpaulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, definitely a bug in my original code.

@jason-ha
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jason-ha
Copy link
Contributor Author

jason-ha commented Oct 2, 2020

@jpaulin Is there someone you can recommend I ping to finish this up? Thanks

@jpaulin
Copy link
Contributor

jpaulin commented Oct 7, 2020

@dignifiedquire Hi, ping, do you happen to know anyone who's got rights to merge PRs into master in Karma's karma-junit-reporter? I'm kind of also left in the chasm of couple of years in between. This PR here is about a small one bug fix. This PR fixes
a bug that caused inaccurate reporting to Sonar. Thanks! /J

@joeyparrish joeyparrish merged commit afa7ca1 into karma-runner:master Oct 7, 2020
@joeyparrish
Copy link
Collaborator

I apologize this project is not better maintained. I was granted write access, but I don't have a lot of experience in this project and I am also not actively maintaining it.

@jason-ha jason-ha deleted the jason-ha/restore-package-name branch October 7, 2020 17:24
@jason-ha
Copy link
Contributor Author

jason-ha commented Oct 7, 2020

Thanks @joeyparrish. Just happy to have the fix in.

@jason-ha
Copy link
Contributor Author

jason-ha commented Oct 7, 2020

@joeyparrish One more request. Can you create a release? (I thought there was one since releases say latest release in Oct 7., but then I notice that year is 2019. So we need one for this year.) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suite (package) name is not prepended to the classname attribute in the testcase element
4 participants