New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: restore suite in classname for old XML #184
fix: restore suite in classname for old XML #184
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, definitely a bug in my original code.
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@jpaulin Is there someone you can recommend I ping to finish this up? Thanks |
@dignifiedquire Hi, ping, do you happen to know anyone who's got rights to merge PRs into master in Karma's karma-junit-reporter? I'm kind of also left in the chasm of couple of years in between. This PR here is about a small one bug fix. This PR fixes |
I apologize this project is not better maintained. I was granted write access, but I don't have a lot of experience in this project and I am also not actively maintaining it. |
Thanks @joeyparrish. Just happy to have the fix in. |
@joeyparrish One more request. Can you create a release? (I thought there was one since releases say latest release in Oct 7., but then I notice that year is 2019. So we need one for this year.) Thanks. |
Fix #179
@jpaulin @dignifiedquire