fix(config): grep is interpreted as regexp

honour regexp characters in the `--grep` argument
karma-runner · May 18, 2015 · 01d11e6 · 01d11e6
1 parent e3ae4e0
commit 01d11e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/adapter.js b/src/adapter.js
@@ -110,11 +110,11 @@ var createMochaStartFn = function(mocha) {
         arrayReduce(clientArguments, function(isGrepArg, arg) {
           var match;
           if (isGrepArg) {
-            mocha.grep(arg);
+            mocha.grep(new RegExp(arg));
           } else if (arg === '--grep') {
             return true;
           } else if (match = /--grep=(.*)/.exec(arg)) {
-            mocha.grep(match[1]);
+            mocha.grep(new RegExp(match[1]));
           }
           return false;
         }, false);

diff --git a/test/adapter.spec.js b/test/adapter.spec.js
@@ -249,7 +249,7 @@ describe('adapter mocha', function() {
         args: ['--grep', 'test test']
       });
 
-      expect(this.mockMocha.grep.getCall(0).args).to.deep.eq(['test test']);
+      expect(this.mockMocha.grep.getCall(0).args).to.deep.eq([/test test/]);
     });
 
     it('should pass grep argument to mocha if we called the run with --grep=xxx', function() {
@@ -259,7 +259,7 @@ describe('adapter mocha', function() {
         args: ['--grep=test test']
       });
 
-      expect(this.mockMocha.grep.getCall(0).args).to.deep.eq(['test test']);
+      expect(this.mockMocha.grep.getCall(0).args).to.deep.eq([/test test/]);
     });
 
     it('should pass grep argument to mocha if config.args contains property grep', function(){