drop Mocha peer dep?

[boneskull]

karma-mocha won't work without Mocha, of course.

But it won't work without Karma, either.

The idea behind peer dependencies is to help support "plugins". karma-mocha is most certainly not a Mocha plugin. So if anything, Karma should be the peer dependency, right?

But a peer dependency is just a static check, really. I'm no big fan of them. Instead of this, what if karma-mocha had a runtime check for a mocha package? Maybe it already does?

Would you accept a PR that drops the peer dep and/or checks for Mocha at runtime?

(Backstory: Mocha is consuming Karma and karma-mocha to run its own tests. Please see mochajs/mocha#2487 for current state of affairs, and how we're trying to work around this.)

[maksimr]

@boneskull karma should be in peer dependencies too like in karma-jasmine

But a peer dependency is just a static check, really.

Yes

I'm no big fan of them. Instead of this, what if karma-mocha had a runtime check for a mocha package?

Why? Why we should add additional code to karma-mocha if this already implemented in npm?

Thanks!

[boneskull]

Why? Why we should add additional code to karma-mocha if this already implemented in npm?

Because the implementation of peer deps is problematic. There's a reason npm v3 reduced unmet peer deps to a warning. Users of npm v3 would have to npm install mocha anyway, so why not change the install instructions in README to something like npm install karma karma-mocha mocha?

FWIW, the code would amount to:

try {
  require('mocha');
} catch (err) {
  throw new Error('karma-mocha requires Mocha; install via "npm install mocha"');
}

The point of this ticket is that I can't use karma-mocha to test Mocha itself without either a) forking karma-mocha or b) really lame workarounds. Dropping the peer dep would solve this problem, at little cost to other users.

[maksimr]

@boneskull thanks, now I understand your pain but how you will resolve problem with require.resolve('mocha')?

[boneskull]

NODE_PATH=. karma start

[maksimr]

@boneskull ok, I have no reason why we can not remove peer dependency.

[boneskull]

@maksimr ping on #116