This repository has been archived by the owner on Dec 28, 2023. It is now read-only.
feat: support mocha opts #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| function normalizeOpts (opts) { | ||
| opts = [ | ||
| 'require', | ||
|
|
There was a problem hiding this comment.
why is there an empty line here?
There was a problem hiding this comment.
@dignifiedquire This line separte options which will pass to mocha in browser from options which use only on the server (like require) and not acceptable in browser
| } | ||
|
|
||
| var extend = require('util')._extend | ||
| return extend(normalizeOpts(require('minimist')(fs.readFileSync(optsPath, 'utf8') |
There was a problem hiding this comment.
Hmm not sure how I fell about using require inline
There was a problem hiding this comment.
@dignifiedquire I have moved all require to top of the file
closes #99
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #99