Remove use of deprecated QUnit.load()
#184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QUnit 2.21.0 will be emitting a deprecation warning from QUnit.load. Calling this method has not been needed for several years, since QUnit 2.1.1, released in 2017. https://github.com/qunitjs/qunit/releases/tag/2.1.1 Also: * document how this works. * remove unused `defaultConfig` parameter. It is only ever used one way in src/, and tests didn't cover other input anyway. It now improves test coverage by covering the actual value instead of relying on tests passing the same as the real code.
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
Mar 4, 2024
Made redundant by karma-runner/karma-qunit#184. Change-Id: If636ec52826c2bdcf1b6809e8ff18e34179cd71d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QUnit 2.21.0 will be emitting a deprecation warning from QUnit.load.
Calling this method has not been needed for several years, since QUnit 2.1.1, released in 2017.
https://github.com/qunitjs/qunit/releases/tag/2.1.1
Also:
defaultConfigparameter. It is only ever used one way in src/, and tests didn't cover other input anyway. It now improves test coverage by covering the actual value instead of relying on tests passing the same as the real code.