Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v4.2.0 #185

Merged
merged 1 commit into from
Feb 9, 2024
Merged

chore: release v4.2.0 #185

merged 1 commit into from
Feb 9, 2024

Conversation

Krinkle
Copy link
Collaborator

@Krinkle Krinkle commented Feb 9, 2024

No description provided.

@Krinkle Krinkle merged commit 659feab into master Feb 9, 2024
11 checks passed
@Krinkle Krinkle deleted the release branch February 9, 2024 14:38
@Krinkle
Copy link
Collaborator Author

Krinkle commented Feb 9, 2024

@XhmikosR Would you mind publishing this to npm and/or adding me as co-owner for the package? I've already merged and tagged the release, but it still needs an npm publish from a git checkout (this release equates latest master as of this moment)

@XhmikosR
Copy link
Collaborator

XhmikosR commented Feb 13, 2024

Hey, @Krinkle. Do you have the commands I need to run to add you as co-owner? I barely use karma-qunit nowadays myself...

On a side note, I wouldn't remove anything in minor version because it's technically a breaking change. I suggest that you revert the removal, make it a patch version 4.2.1 and if you want to remove something bump the version to 5.

@Krinkle
Copy link
Collaborator Author

Krinkle commented Feb 13, 2024

@XhmikosR This doesn't "remove" something (I think?). It changes the internal karma-qunit code to not make use of a deprecated feature. It "removes" a needless call to the QUnit.load function. It still works the same way either way, since QUnit.load is superseded by QUnit.start.

The command to add co-owners to an npm package is https://docs.npmjs.com/cli/v6/commands/npm-owner:

$ cd karma-qunit/
karma-qunit$ npm owner add krinkle

or

$ npm owner add krinkle karma-qunit

@XhmikosR
Copy link
Collaborator

Done!

npm notice INFO: User krinkle invited to package karma-qunit successfully.
+ krinkle (karma-qunit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants