Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files field to package.json #194

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add files field to package.json #194

merged 1 commit into from
Mar 30, 2020

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Mar 30, 2020 •
edited
Loading

Fixes #190 (comment)

Docs: https://docs.npmjs.com/files/package.json#files

Files included with the “package.json#files” field cannot be excluded through .npmignore or .gitignore.

As a nice side-effect, no unnecessary files will be published and users' node_modules folder will be smaller.

image

@limonte limonte mentioned this pull request Mar 30, 2020
Closed
@limonte
Copy link
Contributor Author

limonte commented Mar 30, 2020

The build is failing not because of this PR. Every PR will fail with the current Travis configuration, because env variables SAUCE_* aren't available for PR builds.

@rcebulko
Copy link
Collaborator

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

@limonte
Copy link
Contributor Author

limonte commented Mar 30, 2020

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

No, I can't because I don't have the write permission to this repo.

@rcebulko
Copy link
Collaborator

Can you create this as a branch on this repo? PRs merging from non-karma-runner branches don't get the Sauce credentials required to run a test

No, I can't because I don't have the write permission to this repo.

Okay, I'll just merge it; shouldn't have any impact on tests anyway

@rcebulko rcebulko merged commit f99a0e1 into karma-runner:master Mar 30, 2020
karmarunnerbot pushed a commit that referenced this pull request Mar 30, 2020
@semantic-release-bot
chore(release): 4.1.1 [skip ci]
76978ef 
## [4.1.1](v4.1.0...v4.1.1) (2020-03-30)

### Bug Fixes

* add files field to package.json ([#194](#194)) ([f99a0e1](f99a0e1))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcebulko rcebulko rcebulko approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v4.0.0 is broken, Cannot find plugin "karma-sauce-launcher"
3 participants
@limonte @rcebulko @karmarunnerbot