v4.0.0 is broken, Cannot find plugin "karma-sauce-launcher"

[limonte]

I guess something went wrong with v4.0.0

Cannot find plugin "karma-sauce-launcher".

Can not load reporter "saucelabs", it is not registered!

https://github.com/sweetalert2/sweetalert2/pull/1921/checks?check_run_id=514536203

[limonte]

Yes, it is broken, there's no index.js file in v4.0.0:

[gushiguera-rezi]

same issue here

[limonte]

ping @rcebulko PTAL

[rcebulko]

Indeed, this is a known issue with the release (in the process of configuring semantic release). I think @rsimha knows more

[limonte]

@rcebulko the package is broken for more than 10 days. I can help with the PR, would you be interested in reviewing it?

[rcebulko]

@limonte Certainly

[rcebulko]

@vikerman I see index.js was removed in #156 . This seems to be part of what's breaking the release. Why was it removed, and do you know how to resolve these issues?

[limonte]

Actually, I can't help here. The releasing process is broken completely, the fix isn't simple.

Even the version in package.json is out of sync https://github.com/karma-runner/karma-sauce-launcher/blob/master/package.json#L3

[rcebulko]

Semantic-release uses tags to set the version, and completely ignores package.json. They explicitly disallow "manually" setting the release, since that breaks the semantic part of it. I think I may need to roll back semantic release entirely for now.

[rcebulko]

Part of the issue here is that HEAD is about a year ahead of the previous release. If we just unpublish the latest version from npm, whenever another commit is merged another release will just be triggered and re-deploy the broken version. If @johnjbarton can unpublish the NPM package, I can add a commit disabling semantic-release for the time being, so we can work on the underlying issue, being that master has been broken for probably over a year now.

[limonte]

If @johnjbarton can unpublish the NPM package

Nope, nobody can. https://www.npmjs.com/policies/unpublish

[rcebulko]

I think #190 may address the main problem. When migrating to Typescript, a build step was added to compile to JS. While this was usually done manually, it needs to be done explicitly to populate dist/, and the main entrypoint in package.json had to be updated.

[rcebulko]

It appears NPM ignores files in .gitignore (aka the entire dist/ directory), unless a separate .npmignore file is present. I'm testing this now.

[limonte]

It appears NPM ignores files in .gitignore (aka the entire dist/ directory), unless a separate .npmignore file is present. I'm testing this now.

@rcebulko Should be handled by #194

[karmarunnerbot]

🎉 This issue has been resolved in version 4.1.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[gushiguera-rezi]

👏

[limonte]

Nope, still broken:

There's only package.json inside dist.

[rcebulko]

Oddly, npm pack appears to package up dist/ as desired, and npm publish --dry-run does the same

[limonte]

Oddly, npm pack appears to package up dist/ as desired, and npm publish --dry-run does the same

@rcebulko #196 should handle that 👍 You can test it out with npm publish --dry-run:

[karmarunnerbot]

🎉 This issue has been resolved in version 4.1.2 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[rcebulko]

Looks like that may have done it! Nice 🎉

[limonte]

Looks like that may have done it! Nice tada

Yup, works now 🎉 Thank you @rcebulko 🍻

[rsimha]

Yay! Nice work, @rcebulko and @limonte 😃