Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Doesn't work with karma 0.11.0. #15

Closed
justspamjustin opened this issue Dec 18, 2013 · 8 comments
Closed

Doesn't work with karma 0.11.0. #15

justspamjustin opened this issue Dec 18, 2013 · 8 comments

Comments

@justspamjustin
Copy link

I'm getting this error:
Fatal error: Cannot call method 'push' of undefined

@vojtajina
Copy link
Contributor

I believe this should be fixed by #13

@jussi-kalliokoski
Copy link

I was getting the same error, but now trying against HEAD I get Fatal error: Cannot read property 'log' of undefined, which only happens when karma-teamcity-reporter is enabled. Without it, the log is printed without problems.

Unfortunately I can't really remove the console log since it's made by an external library.

@kolesnik
Copy link

kolesnik commented Jan 7, 2014

Looks like fixed in the last master

@follesoe
Copy link

It looks like the 0.1.1 release tag was created before the fix was merged in (i.e. the currently available karma-teamcity-reporter is incompatible with karma 0.12)?

vvzz pushed a commit to vvzz/karma-teamcity-reporter that referenced this issue Mar 11, 2014
@vvzz
Copy link

vvzz commented Mar 11, 2014

It seems like this might be a different issue, having the same root cause as litixsoft/karma-mocha-reporter#1
I have sent a pull request with a fix

@kenwarner
Copy link

Can you republish with a 0.1.2 version? #15 is already merged to master but not part of the latest 0.1.1 version

@vvzz
Copy link

vvzz commented Mar 24, 2014

I'm a little confused - my pull request already has 0.1.2 version in the package.json? Is there anything else I need to do?

@kenwarner
Copy link

sorry, my comment wasn't directed at you @vvzz. #15 was already merged to master but a new version with this fix was never republished to the npm repository. though we might as well merge your #16 as well before doing the republish at this point

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants