Skip to content

Commit

Permalink
fix(runner): remove explicit error on all tests failed (#3369)
Browse files Browse the repository at this point in the history
* fix(runner): remove explicit error on all tests failed

- there are failOnFailingTestSuite and failOnEmptyTestSuite, so in this there is no neccesity

Fixes #3367

* test(unit): Remove test
  • Loading branch information
ilgonmic authored and johnjbarton committed Oct 10, 2019
1 parent f2eba15 commit f8005c6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
4 changes: 0 additions & 4 deletions lib/browser.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ class Browser {
this.setState(CONNECTED)
this.lastResult.totalTimeEnd()

if (!this.lastResult.success) {
this.lastResult.error = true
}

this.emitter.emit('browsers_change', this.collection)
this.emitter.emit('browser_complete', this, result)

Expand Down
7 changes: 0 additions & 7 deletions test/unit/browser.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,6 @@ describe('Browser', () => {

expect(browser.lastResult.totalTime).to.equal(2)
})

it('should error the result if zero tests executed', () => {
browser.state = Browser.STATE_EXECUTING
browser.onComplete()

expect(browser.lastResult.error).to.equal(true)
})
})

describe('onDisconnect', () => {
Expand Down

0 comments on commit f8005c6

Please sign in to comment.