Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release a new version based on master #1957

Closed
rosenfeld opened this issue Mar 3, 2016 · 12 comments
Closed

Please release a new version based on master #1957

rosenfeld opened this issue Mar 3, 2016 · 12 comments

Comments

@rosenfeld
Copy link

I'd like to write an npm package for integrating oojspec to Karma but it requires the new feature that allows custom context and debug HTML to make it work, so I can't release such package before karma is released with that feature.

I've already got it to work using a symlink to a git clone of karma and I'm currently working on refactoring it and will try to understand how to write frameworks by taking a look at other framework integrations implementation but if you could release a new version of karma that will allow me to publish the new integration package once I'm finished.

@dignifiedquire
Copy link
Member

I'm waiting for a couple of things to get finished and will release 1.0 very soon (hopefully next week) You can track progress for that here: https://github.com/karma-runner/karma/milestones/v1.0

@rosenfeld
Copy link
Author

@dignifiedquire I've implemented the adapter for OOJSpec and I'm just waiting for a new release before publishing it to NPM:

https://github.com/rosenfeld/karma-oojspec

But I think karma should allow plugins to change the custom context and debug files, don't you agree? Please take a look at the notes in the README and on this snippet:

https://github.com/rosenfeld/karma-oojspec/blob/master/src/index.coffee#L2-L4

Could Karma accept such changes to the configuration?

@rosenfeld
Copy link
Author

If you want to see it working, take a look here:

https://github.com/fredericoschardong/karma-oojspec

The tests will fail so that I can test the output properly.

@dignifiedquire
Copy link
Member

@rosenfeld understood :) will try to get things ready on Monday hopefully

re changing the context files, you already do it, so I don't see any issues there. A lot of plugins add or change things on the config for their needs.

@rosenfeld
Copy link
Author

@dignifiedquire, I'm changing the context files in the plugin but it's not working. You can test it by commenting these lines in this project:

https://github.com/fredericoschardong/karma-oojspec/blob/master/karma.conf.coffee#L66-L67

If you do so you'll notice that the custom files are not being loaded even though they are being set by the plugin.

If this is unexpected then it should probably be fixed before releasing 1.0.0, right?

@dignifiedquire
Copy link
Member

Interesting, I expected this to work. Sounds like a bug if it doesn't

@rosenfeld
Copy link
Author

Yes, I also expected it to work, that's why I'm reporting this behavior ;)

@rosenfeld
Copy link
Author

@dignifiedquire, should I create a new issue for that?

@dignifiedquire
Copy link
Member

@rosenfeld Fixed in latest master

@rosenfeld
Copy link
Author

Thanks, @dignifiedquire! I could confirm it now indeed works :) Good job

@dignifiedquire
Copy link
Member

1.0 was just released

@rosenfeld
Copy link
Author

great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants