[question] How to see log of launcher?

[jeanbza]

e.x. karma-phantomjs-launcher / karma-chrome-launcher / karma-script-launcher

[jeanbza]

Am I right in assuming that this piece of code means that there's no way to see launcher output?

[jeanbza]

I was able to replace that code with the following to make it work, but I'd really prefer to have a flag to do this. Would it make sense to PR this?

  var spawnWithoutOutput = function () {
      var proc = spawn.apply(null, arguments)
      proc.stdout.pipe(process.stdout)
      proc.stderr.pipe(process.stderr)

      return proc
    }

    ProcessLauncher.call(launcher, spawnWithoutOutput, require('../temp_dir'), timer)

[maksimr]

This was introduced in #2267 Pull request

[maksimr]

@jadekler

Would it make sense to PR this?

Yes. Maybe better print browser log by default(as before) and hide behind the falg feature from Pull Request #2267 . Because case from #2267

1. Rare
2. Hide errors from the browser and I think it's not so obviously for user, more obviously look at flag which resume browser log (IMHO)

@dignifiedquire what do you think?

[dignifiedquire]

It should be possible to pipe the output from the spawn to the console, without creating the buffer issue. It might be interesting to try out for spawning https://github.com/sindresorhus/execa which I have made good experiences in the past.