Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server.start static method was removed in a patch release #3053

Closed
GreenGremlin opened this issue Jun 18, 2018 · 2 comments
Closed

Server.start static method was removed in a patch release #3053

GreenGremlin opened this issue Jun 18, 2018 · 2 comments

Comments

@GreenGremlin
Copy link
Contributor

Expected behaviour

Patch releases should not break things.

Actual behaviour

v2.0.3 removed the Server.start static method, breaking functionality that worked on v2.0.2.

Environment Details

  • Karma version (output of karma --version): 2.0.3
  • Relevant part of your karma.config.js file N/A

Steps to reproduce the behaviour

  1. Attempt to start a server with require('karma').Server.start({...}).

It looks like the static method has been deprecated for a while, but no warning was given.
@johnjbarton
Copy link
Contributor

Source said
Deprecated since version 0.13, to be removed in 0.14

@johnjbarton johnjbarton mentioned this issue Jun 18, 2018
Merged
@GreenGremlin
Copy link
Contributor Author

I hope it’s not the expectation that consumers read the source before upgrading.

@johnjbarton johnjbarton mentioned this issue Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnjbarton @GreenGremlin