Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load scoped package plugins by default #3656

Closed
hdmr14 opened this issue Feb 20, 2021 · 3 comments · Fixed by #3659
Closed

Load scoped package plugins by default #3656

hdmr14 opened this issue Feb 20, 2021 · 3 comments · Fixed by #3659

Comments

@hdmr14
Copy link
Contributor

hdmr14 commented Feb 20, 2021

Expected behavior

Karma should be able to load plugins with @*/karma-* in their name.

Actual behavior

Karma will only load plugins with names that start with karma-*.
It's incompatible with the scoped package plugins.
When finding plugins, Karma doesn't care about subdirectories, so even if you set the plugins pattern to like @*/karma-*, it will not match anything.

@devoto13
Copy link
Collaborator

I'm not sure if we should do this by default given that it will be a pretty massive breaking change but adding support for scoped packages (with @*/karma-* or similar) sounds reasonable to me. PR is welcome!

@hdmr14
Copy link
Contributor Author

hdmr14 commented Feb 26, 2021

I created PR for scoped packages (as optional, not default).

@karmarunnerbot
Copy link
Member

🎉 This issue has been resolved in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants