Use the full url to determine base url #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of 36cfd96, we are no longer using the full url (https://{url}/redfish/v1/Systems/System.Embedded.1) to derive the base url, which causes self.baseurl to be set incorrectly to "://". Use the updated self.url rather that url. Signed-off-by: Salvatore Daniele <sdaniele@redhat.com>
|
Hello, is it possible to get review on this fix? I believe there was a recent bug introduced that has broken our workflow which relies on this code. i.e. When running insert_iso() we now get the following error
|
SalDaniele
added a commit
to SalDaniele/cluster-deployment-automation
that referenced
this pull request
Jul 5, 2023
Typically we have been able to provide Redfish the iDrac ip alone. However, a bug was introduced recently in aicli which causes insert_iso() to fail due to self.baseurl being set incorrectly. karmab/aicli#45 As a workaround, we can provide the full url instead. Signed-off-by: Salvatore Daniele <sdaniele@redhat.com>
|
my bad, I missed your fix and someone pinged me today on this, resulting on the same fix here at 297e9ce |
|
for the record, the benefit of this change is to remove the need for specifying bmc_model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of f9f6a05, we are no longer using the full url
(https://{url}/redfish/v1/Systems/System.Embedded.1) to derive the base url, which causes self.baseurl to be set incorrectly to "://".
Use the updated self.url rather that url.