Skip to content

Commit

Permalink
clean_up
Browse files Browse the repository at this point in the history
Signed-off-by: zhongjun.li <zhongjun.li@daocloud.io>
  • Loading branch information
learner0810 committed Oct 28, 2021
1 parent 1f87ca9 commit 02f8094
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions charts/_crds/patches/webhook_in_clusterresourcebindings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ spec:
clientConfig:
url: https://karmada-webhook.karmada-system.svc:443/convert
caBundle: {{caBundle}}
# TODO(RainbowMango): After we update controller-runtime to v0.10+, then we can remove `v1beta1`
conversionReviewVersions: ["v1beta1", "v1"]
conversionReviewVersions: ["v1"]
3 changes: 1 addition & 2 deletions charts/_crds/patches/webhook_in_resourcebindings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ spec:
clientConfig:
url: https://karmada-webhook.karmada-system.svc:443/convert
caBundle: {{caBundle}}
# TODO(RainbowMango): After we update controller-runtime to v0.10+, then we can remove `v1beta1`
conversionReviewVersions: ["v1beta1", "v1"]
conversionReviewVersions: ["v1"]
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ spec:
clientConfig:
url: https://{{ $name }}-webhook.{{ $namespace }}.svc:443/convert
{{- include "karmada.webhook.caBundle" . | nindent 8 }}
# TODO(RainbowMango): After we update controller-runtime to v0.10+, then we can remove `v1beta1`
conversionReviewVersions: ["v1beta1", "v1"]
conversionReviewVersions: ["v1"]
---
{{- end -}}
3 changes: 1 addition & 2 deletions charts/templates/_patch_webhook_in_resourcebindings.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ spec:
clientConfig:
url: https://{{ $name }}-webhook.{{ $namespace }}.svc:443/convert
{{- include "karmada.webhook.caBundle" . | nindent 8 }}
# TODO(RainbowMango): After we update controller-runtime to v0.10+, then we can remove `v1beta1`
conversionReviewVersions: ["v1beta1", "v1"]
conversionReviewVersions: [v1"]
---
{{- end -}}

0 comments on commit 02f8094

Please sign in to comment.