Support --image-mirror-country or --image-repositor like minikube

[chaunceyjiang]

Hi,i can't download these images k8s.gcr.io/etcd:3.5.1-0,k8s.gcr.io/kube-controller-manager:v1.21.7,k8s.gcr.io/kube-apiserver:v1.21.7

For many mainland users, specifying the --image-mirror-country parameter may be more convenient than specifying their image repository separately.

Such as minikube ,for Chinese mainland users, set it to cn.

minikube --image-mirror-country

[RainbowMango]

I guess what you are talking about is the karmadactl init flags, right?

I'll look at how minikube use this flag. Does this just affect the images in k8s.gcr.io?

[wuyingjun-lucky]

@RainbowMango @chaunceyjiang Can I do some work on the issue ？

[RainbowMango]

For this issue, we haven't made final decisions yet.

Anyone can take any issue so long as the Assignees list is still empty.

[wuyingjun-lucky]

/assign

[chaunceyjiang]

I guess what you are talking about is the karmadactl init flags, right?

yes

[RainbowMango]

I checked some minikube code, and found that it maintains the available image repositories for different countries:

	// ImageRepositories contains all known image repositoriesAnders F Björklund, 2 years ago: • Add comments to avoid warnings from go lint
	ImageRepositories = map[string][]string{Medya Ghazizadeh, 2 years ago: • Add podman driver (#6515)
		"global": {""},Zhongcheng Lao, 3 years ago: • Triggers repository detection only when --ima…
		"cn":     {"registry.cn-hangzhou.aliyuncs.com/google_containers"},Zhongcheng Lao, 3 years ago: • Select an accessible image repository for som…
	}

And It also checked if the repository is accessible.
https://github.com/kubernetes/minikube/blob/f51fc4ccaccb333c57795dbdb9b138fa09bb3a91/cmd/minikube/cmd/start.go#L868-L906

[wuyingjun-lucky]

https://github.com/kubernetes/minikube/blob/f51fc4ccaccb333c57795dbdb9b138fa09bb3a91/cmd/minikube/cmd/start.go#L868-L906

Do you suggest to check repo as that or skip checking

https://github.com/kubernetes/minikube/blob/f51fc4ccaccb333c57795dbdb9b138fa09bb3a91/cmd/minikube/cmd/start.go#:~:text=err%20%3A%3D-,checkRepository,-(v%2C

[wuyingjun-lucky]

/close
As #1764 closed

[karmada-bot]

@wuyingjun-lucky: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close
As #1764 closed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RainbowMango]

/close

@wuyingjun-lucky Maybe you can use this command after you become a member of Karmada. You can file an issue for the membership.

[karmada-bot]

@RainbowMango: Closing this issue.

In response to this:

/close

@wuyingjun-lucky Maybe you can use this command after you become a member of Karmada. You can file an issue for the membership.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wuyingjun-lucky]

/close

@wuyingjun-lucky Maybe you can use this command after you become a member of Karmada. You can file an issue for the membership.

OK, thank you