Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to use local-up-karmada.sh to setup Karmada on Mac when set ChinaMainland #2114

Closed
Poor12 opened this issue Jul 3, 2022 · 3 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@Poor12
Copy link
Member

Poor12 commented Jul 3, 2022

Task description:
When use local-up-karmada.sh to setup Karmada on Mac, if use ChinaMainland, it will run some scripts to override default images.

  for dockerfile in "${dockerfile_list[@]}"; do
    grep 'mirrors.ustc.edu.cn' ${repo_root}/${dockerfile} > /dev/null || sed -i'' -e "s#FROM alpine:3.15.1#FROM alpine:3.15.1\nRUN echo -e http://mirrors.ustc.edu.cn/alpine/v3.15/main/ > /etc/apk/repositories#" ${repo_root}/${dockerfile}
  done

However, macos do not use \n to line feed. So it will like below:
截屏2022-07-03 下午9 52 37
So build image failed.

Solution:

Who can join or take the task:

The good first issue is intended for first-time contributors to get started on his/her contributor journey.

After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to help wanted items, saving the remaining good first issue for other new contributors.

How to join or take the task:

Just reply on the issue with the message /assign in a separate line.

Then, the issue will be assigned to you.

How to ask for help:

If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.

@Poor12 Poor12 added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 3, 2022
@kinzhi
Copy link
Contributor

kinzhi commented Jul 4, 2022

/assign

@ikaven1024
Copy link
Member

ikaven1024 commented Jul 8, 2022

@Poor12 What's your mac version? It works well on my side: MacOS 11 & 12

@Poor12
Copy link
Member Author

Poor12 commented Jul 9, 2022

@Poor12 What's your mac version? It works well on my side: MacOS 11 & 12

10.15.7. Catalina.

@Poor12 Poor12 closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants