Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dockerfile line feed problem #2145

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

kinzhi
Copy link
Contributor

@kinzhi kinzhi commented Jul 7, 2022

What type of PR is this?
Fixed dockerfile line feed problem

Add one of the following kinds:

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes ##2114

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 7, 2022
@karmada-bot
Copy link
Collaborator

Welcome @kinzhi! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2022
Signed-off-by: Kinzhi <wei.wang@daocloud.io>
@RainbowMango
Copy link
Member

/assign @Poor12

@Poor12
Copy link
Member

Poor12 commented Jul 8, 2022

Could you show some test results?

@kinzhi
Copy link
Contributor Author

kinzhi commented Jul 8, 2022

Could you show some test results?

Before:
image

Modify the content:
image

After:
image

@Poor12
Copy link
Member

Poor12 commented Jul 8, 2022

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2022
@RainbowMango
Copy link
Member

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2022
@karmada-bot karmada-bot merged commit 36dc007 into karmada-io:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants