Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let karmada cluster sync CRD from member clusters #419

Closed
vincent-pli opened this issue Jun 5, 2021 · 16 comments
Closed

Let karmada cluster sync CRD from member clusters #419

vincent-pli opened this issue Jun 5, 2021 · 16 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vincent-pli
Copy link
Contributor

What would you like to be added:
Let Karmada cluster sync CRD from member cluster

Why is this needed:
Karmada cluster will create template and sync to member cluster, that's great.
but for CRD scenario, if there is no such CRD in the karmada cluster but has installed in the member cluster, that is a mass that user need apply such CRDs both in karmada cluster and member cluster.

@vincent-pli vincent-pli added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2021
@RainbowMango
Copy link
Member

That might be an interesting feature. Can we have a chat about this in next week's meeting?

@GitHubxsy
Copy link
Contributor

Sounds cool.

@vincent-pli
Copy link
Contributor Author

Sure, thanks @RainbowMango

@mrlihanbo
Copy link

Sounds cool. Need to consider the scenario of pull mode cluster

@RainbowMango
Copy link
Member

Sure, thanks @RainbowMango

@vincent-pli I haven't seen the agenda on today's meeting.

@vincent-pli
Copy link
Contributor Author

Missing the meeting, block by a full day tough training, sorry for that @RainbowMango

@RainbowMango
Copy link
Member

No worries. We can still discuss this here.

@pigletfly
Copy link
Contributor

Brilliant idea.I think we can provide a field to tell karmada if there is a existed workload in member cluster, should it be adopted or just leave it alone.

@RainbowMango
Copy link
Member

Hi @vincent-pli Looking forward to meeting you at the community meeting and talking about this feature there. I'm sure it would be a wonderful feature.

@merryzhou
Copy link

hi,I am also interested in this feature, any news?

@RainbowMango
Copy link
Member

Hi @merryzhou
No, if I remember right, we haven't discussed it yet. I don't know if @vincent-pli is still interested in this topic.

@merryzhou maybe you can lead the effort to move this forward. I get your back.

My idea is to provide a controller (just like the namespace controller) to propagate the CRD to member clusters automatically.

By the way, I'm preparing the draft roadmap of 2022, this feature will be included there.

@merryzhou
Copy link

@merryzhou maybe you can lead the effort to move this forward

ok, I'd like to have a try.

My idea is to provide a controller (just like the namespace controller) to propagate the CRD to member clusters automatically.

I think this issue is about sync CRD from member clusters, not propagate the CRD to member clusters?

@RainbowMango
Copy link
Member

RainbowMango commented Mar 10, 2022

I think this issue is about sync CRD from member clusters, not propagate the CRD to member clusters?

I have a different opinion. Sync CRD from Karmada to member clusters should have higher priority at least.

If the CRD resources are already in the member clusters, they only need to sync once( to Karmada), I can't see much pain from that.

@merryzhou
Copy link

Sync CRD from Karmada to member clusters should have higher priority at least.

we can open a new issue about this。

@RainbowMango
Copy link
Member

I'm going to close this as its lacks activities for a long time.

Please feel free to re-open it if anyone thinks it is needed.

/close

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

I'm going to close this as its lacks activities for a long time.

Please feel free to re-open it if anyone thinks it is needed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants