-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug of resource computing #1225
Conversation
Signed-off-by: Garrybest <garrybest@foxmail.com>
cc @huone1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how and when the SetDefaults_Pod executed? Does the karmada-apiserver
also set the defaults for Pod?
The api-server mutating webhook will set the default values. See here |
the overhead resource data should be obtained through by RuntimeClass; the podtemplate shouldn't have the overhead info and the POD instance just contain the the overhead info |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Discussed this with @huone1 locally, I get his concern now. Since the |
Signed-off-by: Garrybest garrybest@foxmail.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: