Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce --resync-period flag to specify reflector resync period #1261

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Introduce --resync-period flag to specify reflector resync period #1261

merged 1 commit into from
Jan 25, 2022

Conversation

Garrybest
Copy link
Member

@Garrybest Garrybest commented Jan 14, 2022 •
edited by RainbowMango
Loading

Signed-off-by: Garrybest garrybest@foxmail.com

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes part of #1260

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`/`karmada-agent`: introduced `--resync-period` flag to specify reflectors resync period(defaults to 0 means no resync)

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 14, 2022
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 14, 2022
@Garrybest Garrybest force-pushed the pr_slow branch 2 times, most recently from 6f39d47 to 773a828 Compare January 21, 2022 02:25
@Garrybest
Copy link
Member Author

/cc @XiShanYongYe-Chang

@RainbowMango
Copy link
Member

/remove-kind bug
/kind feature

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 21, 2022
@Garrybest
add resync period option
012f0ca 
Signed-off-by: Garrybest <garrybest@foxmail.com>
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Jan 22, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 22, 2022
@RainbowMango
Copy link
Member

/retitle Introduce --resync-period flag to specify reflector resync period

@karmada-bot karmada-bot changed the title add resync period option Introduce --resync-period flag to specify reflector resync period Jan 25, 2022
RainbowMango
RainbowMango reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@karmada-bot karmada-bot merged commit 85554ff into karmada-io:master Jan 25, 2022
@Garrybest Garrybest deleted the pr_slow branch January 25, 2022 07:40
@RainbowMango RainbowMango mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Garrybest @RainbowMango @karmada-bot @XiShanYongYe-Chang