Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin clusterLocality to favor cluster #1334

Merged
merged 1 commit into from Mar 26, 2022

Conversation

huone1
Copy link
Contributor

@huone1 huone1 commented Jan 30, 2022

Signed-off-by: huone1 huwanxing@huawei.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
Currently, the spreadConstraint choose clusters just by clusterName.
in the rescheduling scenario, we hope the replicas in the scheduled clusters are not Migrated when they meet the filter conditions.
The plugin clusterlocality is aim to supply the preferred policy to favors cluster that already have requested.
Which issue(s) this PR fixes:
a part of #1330

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-scheduler`: Added a score plugin `clusterLocality` to favor clusters that already has requested.

@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 30, 2022
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 30, 2022
@huone1 huone1 force-pushed the feature/clusterlocality branch 2 times, most recently from b735cbb to a19cc21 Compare February 7, 2022 02:45
@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2022
Signed-off-by: huone1 <huwanxing@huawei.com>
@huone1 huone1 changed the title [WIP]add plugin clusterLocality to favor cluster add plugin clusterLocality to favor cluster Mar 25, 2022
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2022
@huone1
Copy link
Contributor Author

huone1 commented Mar 25, 2022

/cc @RainbowMango

@mrlihanbo
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2022
@karmada-bot karmada-bot merged commit 431677b into karmada-io:master Mar 26, 2022
@huone1 huone1 deleted the feature/clusterlocality branch April 22, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants