Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rbac in karmada_agent.yaml for charts #1457

Merged
merged 1 commit into from Mar 9, 2022
Merged

fix rbac in karmada_agent.yaml for charts #1457

merged 1 commit into from Mar 9, 2022

Conversation

AllenZMC
Copy link
Member

@AllenZMC AllenZMC commented Mar 8, 2022 •
edited by RainbowMango

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix rbac in karmada_agent.yaml for charts
Which issue(s) this PR fixes:
Fixes #1396

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`helm-chart`: fixed can't install karmada-agent as lack of permission issue.

fix karmada_agent.yaml for charts
5788de4 
Signed-off-by: AllenZMC <zhongming.chang@daocloud.io>
@karmada-bot karmada-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 8, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2022
@AllenZMC
Copy link
Member Author

AllenZMC commented Mar 9, 2022

/assign @RainbowMango

@XiShanYongYe-Chang
Copy link
Member

This pr seems to have fixed the #1396, can you associate it?

@XiShanYongYe-Chang
Copy link
Member

I saw @prodanlabs commented on this pr, but not sure why it doesn't show up here. The comment is:

hi @AllenZMC Could you please modify the karmadactl init examples as well?
https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/cmdinit/utils/examples.go#L24

@AllenZMC
Copy link
Member Author

AllenZMC commented Mar 9, 2022 •
edited

OK，I will do it.

@XiShanYongYe-Chang
Copy link
Member

I saw @prodanlabs commented on this pr, but not sure why it doesn't show up here. The comment is:

hi @AllenZMC Could you please modify the karmadactl init examples as well?
https://github.com/karmada-io/karmada/blob/master/pkg/karmadactl/cmdinit/utils/examples.go#L24

Sorry, this has been modified. Please ignore it.

@AllenZMC
Copy link
Member Author

AllenZMC commented Mar 9, 2022

Fixes #1396

@AllenZMC
Copy link
Member Author

AllenZMC commented Mar 9, 2022

/assign @XiShanYongYe-Chang

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2022
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Mar 9, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Mar 9, 2022
Closed
@karmada-bot karmada-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 9, 2022
RainbowMango
RainbowMango approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2022
@karmada-bot karmada-bot merged commit 636cd15 into karmada-io:master Mar 9, 2022
@AllenZMC AllenZMC deleted the fix_rbac branch March 9, 2022 14:58
@AllenZMC AllenZMC mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@jrkeen jrkeen Awaiting requested review from jrkeen

Assignees

@RainbowMango RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot reconcile clusterRole/clusterRoleBinding karmada-impersonator
4 participants
@AllenZMC @XiShanYongYe-Chang @karmada-bot @RainbowMango