make webhook server certificate name and key name configurable #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
karmada-bot
added
the
size/S
|
Please help add a release note. |
RainbowMango
approved these changes
Mar 11, 2022
karmada-bot
added
the
do-not-merge/hold
karmada-bot
added
lgtm
|
/remove-approve |
karmada-bot
removed
the
approved
cmd/webhook/app/options/options.go
Outdated
| @@ -57,7 +60,9 @@ func (o *Options) AddFlags(flags *pflag.FlagSet) { | |||
| flags.IntVar(&o.SecurePort, "secure-port", defaultPort, | |||
| "The secure port on which to serve HTTPS.") | |||
| flags.StringVar(&o.CertDir, "cert-dir", defaultCertDir, | |||
| "The directory that contains the server key(named tls.key) and certificate(named tls.crt).") | |||
| "The directory that contains the server key and certificate.") | |||
| flags.StringVar(&o.CertName, "cert-name", "tls.crt", "The name of server certificate.") | |||
There was a problem hiding this comment.
Suggested change
| flags.StringVar(&o.CertName, "cert-name", "tls.crt", "The name of server certificate.") | |
| flags.StringVar(&o.CertName, "tls-cert-file-name", "tls.crt", "The name of server certificate.") |
cmd/webhook/app/options/options.go
Outdated
| "The directory that contains the server key(named tls.key) and certificate(named tls.crt).") | ||
| "The directory that contains the server key and certificate.") | ||
| flags.StringVar(&o.CertName, "cert-name", "tls.crt", "The name of server certificate.") | ||
| flags.StringVar(&o.KeyName, "key-name", "tls.key", "The name of server key.") |
There was a problem hiding this comment.
Suggested change
| flags.StringVar(&o.KeyName, "key-name", "tls.key", "The name of server key.") | |
| flags.StringVar(&o.KeyName, "tls-private-key-file-name", "tls.key", "The name of server key.") |
Signed-off-by: lihanbo <lihanbo2@huawei.com>
karmada-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lihanbo lihanbo2@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Make webhook server certificate name and key name configurable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: