Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable hpa controller by default #1580

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Apr 6, 2022

What type of PR is this?
/kind deprecation

What this PR does / why we need it:
disable hpa controller by default
1

Which issue(s) this PR fixes:
Fixes #1569

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: The `hpa` controller is disabled by default now.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 6, 2022
@karmada-bot
Copy link
Collaborator

Welcome @Poor12! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2022
@RainbowMango
Copy link
Member

cc @YueHonghui @snowplayfire
As we discussed at the last meeting, we will disable the hpa controller.

@RainbowMango RainbowMango added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. and removed kind/bug Categorizes issue or PR as related to a bug. labels Apr 6, 2022
Signed-off-by: Poor12 <shentiecheng@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle disable hpa controller by default

@karmada-bot karmada-bot changed the title fix 1589-disable hpa controller disable hpa controller by default Apr 6, 2022
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
@karmada-bot karmada-bot merged commit ab0a90e into karmada-io:master Apr 6, 2022
@Poor12 Poor12 deleted the fix-1569 branch July 24, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate hpa controller
3 participants