New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add outOfTree plugin entry when initializing scheduler #1663
feat: add outOfTree plugin entry when initializing scheduler #1663
Conversation
I was try to add e2e test, but didn't find any place to change the configuration in initializing scheduler. |
cc @huone1 |
9ad1f17
to
2e35f2b
Compare
Signed-off-by: kerthcet <kerthcet@gmail.com>
2e35f2b
to
84cc6f8
Compare
Sorry for the long delayed response, out of bandwidth in the past weeks. Can you help me with this @huone1 , I would like to add some integration tests or e2e tests. But have no idea how to initialize scheduler in karmada's test framework. |
@prodanlabs Is this extension way you are looking for? |
@kerthcet Sorry for let this sit, I'll look at it and get back to you(probably next week.) |
FYI, it we merged this, we can extend out-of-tree plugin like below when instantiating the scheduler.
|
This function is what we need. Every time you upgrade karmada, you need to recompile karmada-scheduler. It would be better if it can support external expansion. Of course, this can be discussed separately. |
Hi @kerthcet ,still need to hardcode, right? |
Yes, you have to compile yourself. Here's another way the kubernetes community is looking for, but still exploring. kubernetes/kubernetes#100723 |
Thanks. |
Thanks @kerthcet and sorry again for letting this sit so long. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Note: I added a release note to the PR description, this is a significant feature that should be present in the next releases. |
Signed-off-by: kerthcet kerthcet@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1371
Special notes for your reviewer:
Now we can initialize OutOfTree Plugin like below, then we can compile customized karmada scheduler.
Does this PR introduce a user-facing change?: