Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated flags for karmada-aggregated-apiserver #1834

Merged
merged 1 commit into from
May 25, 2022
Merged

remove deprecated flags for karmada-aggregated-apiserver #1834

merged 1 commit into from
May 25, 2022

Conversation

AllenZMC
Copy link
Member

@AllenZMC AllenZMC commented May 19, 2022 •
edited
Loading

What type of PR is this?
/kind feature
/kind cleanup

What this PR does / why we need it:
karmada-aggregated-apiserver: The deprecated flags --karmada-config and --master in v1.1 have been removed from the codebase.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-aggregated-apiserver`: The deprecated flags `--karmada-config` and `--master` in v1.1 have been removed from the codebase.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 19, 2022
@karmada-bot karmada-bot requested a review from lonelyCZ May 19, 2022 08:34
@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 19, 2022
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2022
@XiShanYongYe-Chang
Copy link
Member

This change should be made after #1807.

@AllenZMC
Copy link
Member Author

/cc @XiShanYongYe-Chang

@XiShanYongYe-Chang
Copy link
Member

Hi @AllenZMC, can you rebase the master branch?

@karmada-bot karmada-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2022
remove deprecated flags
6c711c8 
Signed-off-by: AllenZMC <zhongming.chang@daocloud.io>
@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2022
@AllenZMC
Copy link
Member Author

@XiShanYongYe-Chang solved.

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed May 24, 2022
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@AllenZMC
Copy link
Member Author

/cc @RainbowMango

RainbowMango
RainbowMango approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@RainbowMango
Copy link
Member

/hold
We need a release note.

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2022
@AllenZMC
Copy link
Member Author

AllenZMC commented May 24, 2022 •
edited
Loading

/hold We need a release note.

What do you think of this content: Remove karmada-config flag in karmada-aggregated-apiserver

@RainbowMango
Copy link
Member 

`karmada-aggregated-apiserver`: The flags `--karmada-config` and `--master` which were deprecated at v1.1 now has been removed from the codebase.

How about this?

@AllenZMC
Copy link
Member Author

AllenZMC commented May 25, 2022 •
edited
Loading

@RainbowMango
What do you think of this description?

`karmada-aggregated-apiserver`: The deprecated flags `--karmada-config` and `--master` in v1.1 have been removed from the codebase.

@RainbowMango
Copy link
Member

Sounds good to me.

@AllenZMC AllenZMC changed the title remove deprecated flags remove deprecated flags for karmada-aggregated-apiserver May 25, 2022
@RainbowMango
Copy link
Member

/hold cancel

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@karmada-bot karmada-bot merged commit 139683d into karmada-io:master May 25, 2022
@AllenZMC AllenZMC deleted the fix branch May 26, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AllenZMC @XiShanYongYe-Chang @karmada-bot @RainbowMango