add ProxyHeader API #1874
Merged
add ProxyHeader API #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
the
kind/api-change
karmada-bot
added
the
size/M
mrlihanbo
force-pushed
the
proxy-header-api
branch
from
31a4190
to
ed11149
Compare
mrlihanbo
force-pushed
the
proxy-header-api
branch
from
ed11149
to
5dca803
Compare
pkg/apis/cluster/v1alpha1/types.go
Outdated
Comment on lines
76
to
79
| // ProxyHeader optionally specifies headers to send to | ||
| // proxy configured in ProxyURL. | ||
| // The map keys are the HTTP header names, and the values are the associated header payloads. | ||
| // For the header with multiple values, the map value should be a comma-separated string(e.g. 'Content-Length: 0,1,2') | ||
| // +optional |
There was a problem hiding this comment.
Suggested change
| // ProxyHeader optionally specifies headers to send to | |
| // proxy configured in ProxyURL. | |
| // The map keys are the HTTP header names, and the values are the associated header payloads. | |
| // For the header with multiple values, the map value should be a comma-separated string(e.g. 'Content-Length: 0,1,2') | |
| // +optional | |
| // ProxyHeader is the HTTP header required by proxy server. | |
| // The key in the key-value pair is HTTP header key and value is the associated header payloads. | |
| // For the header with multiple values, the values should be separated by comma(e.g. 'k1': 'v1,v2,v3'). | |
| // +optional |
Looks good to me. Please talk to @kevin-wangzefeng and @GitHubxsy as well.
Signed-off-by: lihanbo <lihanbo2@huawei.com>
mrlihanbo
force-pushed
the
proxy-header-api
branch
from
5dca803
to
08833eb
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lihanbo lihanbo2@huawei.com
What type of PR is this?
/kind api-change
What this PR does / why we need it:
As described in #257, some member clusters are behind a proxy. And some proxies will request clients to provide necessary headers during a CONNECT request, like authorization information.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
none
Does this PR introduce a user-facing change?: